Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove epsilon scheduler in GW #508

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Remove epsilon scheduler in GW #508

merged 1 commit into from
Mar 28, 2024

Conversation

michalk8
Copy link
Collaborator

Unnecessary + causes issues when passing a custom initialization (where epsilon is usually not passed/passed via the solver, not the geometry).

@michalk8 michalk8 added the enhancement New feature or request label Mar 27, 2024
@michalk8 michalk8 self-assigned this Mar 27, 2024
@michalk8 michalk8 added bug Something isn't working and removed enhancement New feature or request labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.64%. Comparing base (b6ea832) to head (0d2b1e5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   90.63%   90.64%           
=======================================
  Files          60       60           
  Lines        6688     6682    -6     
  Branches      957      956    -1     
=======================================
- Hits         6062     6057    -5     
  Misses        477      477           
+ Partials      149      148    -1     
Files Coverage Δ
src/ott/initializers/quadratic/initializers.py 81.48% <100.00%> (ø)
src/ott/problems/quadratic/quadratic_problem.py 81.31% <100.00%> (-0.07%) ⬇️

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@marcocuturi marcocuturi merged commit 41906a2 into main Mar 28, 2024
13 checks passed
@marcocuturi marcocuturi deleted the fix/gw-eps-scheduler branch March 28, 2024 10:35
michalk8 added a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants