Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maint/third lower bound #507

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Maint/third lower bound #507

merged 3 commits into from
Mar 27, 2024

Conversation

michalk8
Copy link
Collaborator

Cleans the implementation of the 3rd lower bound of GW.

@michalk8 michalk8 self-assigned this Mar 27, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@michalk8 michalk8 added the misc label Mar 27, 2024
@marcocuturi
Copy link
Contributor

LGTM!

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.63%. Comparing base (9eed305) to head (3d42434).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   90.61%   90.63%   +0.02%     
==========================================
  Files          60       60              
  Lines        6703     6688      -15     
  Branches      958      957       -1     
==========================================
- Hits         6074     6062      -12     
+ Misses        480      477       -3     
  Partials      149      149              
Files Coverage Δ
src/ott/solvers/linear/sinkhorn.py 99.38% <100.00%> (-0.01%) ⬇️
src/ott/solvers/linear/sinkhorn_lr.py 98.64% <100.00%> (-0.01%) ⬇️
src/ott/solvers/quadratic/gromov_wasserstein.py 86.56% <100.00%> (+1.38%) ⬆️
src/ott/solvers/quadratic/gromov_wasserstein_lr.py 81.60% <0.00%> (-0.06%) ⬇️
src/ott/solvers/quadratic/lower_bound.py 75.00% <77.77%> (-6.49%) ⬇️

@michalk8 michalk8 merged commit b6ea832 into main Mar 27, 2024
13 checks passed
@michalk8 michalk8 deleted the maint/third-lower-bound branch March 27, 2024 15:43
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Use `jax.debug.callback`

* Update tutorial

* Clean `LowerBoundSolver`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants