Fix heat scaling #481
Merged
Fix heat scaling #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 60 60
Lines 6549 6549
Branches 933 933
=======================================
Hits 5929 5929
Misses 472 472
Partials 148 148
|
michalk8
requested changes
Dec 22, 2023
michalk8
approved these changes
Dec 27, 2023
|
Perfect @michalk8 , thank you for reviewing the PR! |
michalk8
pushed a commit
that referenced
this pull request
Jun 27, 2024
* scale for the eigval * eigval for comb. Lap. * add test for heat kernel * `t=eps/4.0` * formatting * atol rtol test `test_geometry_differentiability` * formatting & test `order` and `t`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MUCDK noticed that the Chebyshev approximation was producing results different than another library.
This PR fixes the scaling of the eigenvalue needed to compute the coefficients of the polynomials. There was also a problem with the eigenvalue of the rescaled Laplacian; we computed the coefficients with the eigenvalue prior to the rescaling. We now use the eigenvalue of the rescaled Laplacian (always equal to
2.0) .Now we also test if the approximated heat kernel is close to the ground truth one.