Fix/rank2 init #442
Merged
Fix/rank2 init #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 57 57
Lines 6254 6256 +2
Branches 884 884
=======================================
+ Hits 5664 5666 +2
Misses 448 448
Partials 142 142
|
|
Thanks Michal, LGTM! (remove fast gpu tests?) |
Will check/do in a later PR! |
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* Fix jax casting in rank2 initializer * Switch to `https` * Fix spellchecker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes integer overflow for rank2 initialization. Also fixes the docs linter.