[ENH]: Fix misc typos in soft_sort doc #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcocuturi
approved these changes
Jul 18, 2023
|
|
||
| will output a vector of shape ``x.shape``, with values in :math:`[0,1]`, that | ||
| are differentiable approximations to the binary mask selecting the top $k$ | ||
| entries in ``x``. These should be compared to the non-differentiable mask | ||
| obtained with :func:`jax.numpy.argsort`, which can be obtained as: | ||
| obtained with :func:`jax.numpy.sort`, which can be obtained as: |
There was a problem hiding this comment.
good point... maybe my definition of topk below is a bit ambiguous, since it can return more than k values with ties.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.