-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes in definition of Monge gap #389
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 88.05% 88.58% +0.52%
==========================================
Files 55 55
Lines 5944 5947 +3
Branches 867 867
==========================================
+ Hits 5234 5268 +34
+ Misses 582 552 -30
+ Partials 128 127 -1
|
thanks Michal! |
@theouscidda6 for visibility of this change |
* changes in definition of Monge gap * fixes following review * fixes * typos
Follows this comment :
#361 (comment)
I now split two expressions, a Monge gap for samples, and one that takes a model as input.