Fine grained control of Bures barycenters #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 88.24% 88.43% +0.19%
==========================================
Files 51 51
Lines 5531 5605 +74
Branches 831 836 +5
==========================================
+ Hits 4881 4957 +76
+ Misses 530 529 -1
+ Partials 120 119 -1
|
michalk8
requested changes
Jun 2, 2023
michalk8
requested changes
Jun 2, 2023
|
Thanks a lot Michal for the tight quality control!! |
michalk8
pushed a commit
that referenced
this pull request
Jun 27, 2024
* more granularity into computation of Bures barycenter * linter * pydocs * solve tuple issues w.r.t barycenter in elsewhere * lint * solved comments * comments * missing **kwargs : Any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fine grained control on Gaussian (Bures) barycenters by allowing to parameterise:
kwargsfor the sqrtm calls used inside the barycenterAlso,
def barycenter(...)member functions incost_fnare now expected to return a list, of which the barycenter is the first element, the second being any relevant auxiliary information on convergence. For Bures this is norms of successive differences between iterates.