Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertions in cost functions #340

Merged
merged 7 commits into from
Mar 22, 2023

Conversation

michalk8
Copy link
Collaborator

No description provided.

@michalk8 michalk8 added the enhancement New feature or request label Mar 22, 2023
@michalk8 michalk8 self-assigned this Mar 22, 2023
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@michalk8 michalk8 merged commit 954a158 into ott-jax:main Mar 22, 2023
@michalk8 michalk8 deleted the fix/costs-assertions branch March 22, 2023 14:29
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Remove assertions

* Use `jnp.where`

* Fix missing 2nd `jnp.where`

* Fix `PointCloud` link in tutorial

* Use `jax.lax.cond`

* Don't make `p` in costs traceable

* Fix children not being iterable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants