Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/jit inside jit #335

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Fix/jit inside jit #335

merged 5 commits into from
Mar 17, 2023

Conversation

michalk8
Copy link
Collaborator

TODOs:

  • create the "sharp bits"-like page

closes #312

@michalk8 michalk8 added bug Something isn't working deprecation labels Mar 15, 2023
@michalk8 michalk8 self-assigned this Mar 15, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

Merging #335 (27bf935) into main (db689bd) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   88.59%   88.32%   -0.28%     
==========================================
  Files          51       51              
  Lines        5479     5472       -7     
  Branches      824      824              
==========================================
- Hits         4854     4833      -21     
- Misses        509      522      +13     
- Partials      116      117       +1     
Impacted Files Coverage Δ
src/ott/solvers/was_solver.py 88.09% <ø> (-7.26%) ⬇️
src/ott/solvers/linear/continuous_barycenter.py 93.75% <100.00%> (-0.10%) ⬇️
src/ott/solvers/linear/sinkhorn.py 96.83% <100.00%> (-0.02%) ⬇️
src/ott/solvers/linear/sinkhorn_lr.py 96.17% <100.00%> (-0.02%) ⬇️
src/ott/solvers/quadratic/gromov_wasserstein.py 89.31% <100.00%> (-3.87%) ⬇️
src/ott/solvers/quadratic/gw_barycenter.py 91.26% <100.00%> (-5.86%) ⬇️

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can either push or add the sharp bits page, as you prefer

@michalk8 michalk8 marked this pull request as ready for review March 17, 2023 13:02
@michalk8
Copy link
Collaborator Author

LGTM, we can either push or add the sharp bits page, as you prefer

Thanks, let's do the page later!

@michalk8 michalk8 merged commit 9197555 into ott-jax:main Mar 17, 2023
@michalk8 michalk8 deleted the fix/jit-inside-jit branch March 17, 2023 13:33
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Remove `jit` argument from solvers

* Add banner

* Polish Getting Started tutorial

* Update pygments style

* Remove `jit` from tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jit inside jit sometimes fails
3 participants