Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sinkdiv hessian #321

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Fix/sinkdiv hessian #321

merged 3 commits into from
Feb 27, 2023

Conversation

michalk8
Copy link
Collaborator

closes #320

@michalk8 michalk8 added the bug Something isn't working label Feb 27, 2023
@michalk8 michalk8 self-assigned this Feb 27, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

Merging #321 (8fd8fdb) into main (05ff6dd) will decrease coverage by 0.05%.
The diff coverage is 57.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   88.76%   88.72%   -0.05%     
==========================================
  Files          52       52              
  Lines        5670     5676       +6     
  Branches      859      860       +1     
==========================================
+ Hits         5033     5036       +3     
- Misses        509      511       +2     
- Partials      128      129       +1     
Impacted Files Coverage Δ
src/ott/tools/sinkhorn_divergence.py 94.82% <33.33%> (-3.36%) ⬇️
src/ott/solvers/linear/implicit_differentiation.py 96.15% <75.00%> (-1.18%) ⬇️

@marcocuturi
Copy link
Contributor

Thanks Michal! LGTM, but it seems the plot is gone?

@michalk8 michalk8 merged commit a7a0c72 into ott-jax:main Feb 27, 2023
@michalk8 michalk8 deleted the fix/sinkdiv-hessian branch February 27, 2023 21:13
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Use symmetric in `sinkhorn_divergence`

* Re-run notebook

* [ci skip] Regenerate notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implicit parameter not used in the Sinkhorn Divergence Hessians notebook?
3 participants