add primal_cost property to output of GW, to compute cost without any regularization.
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcocuturi
changed the title
primal_cost property to output of GW, to compute cost without any regularization.
michalk8
requested changes
Feb 15, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 85.93% 85.95% +0.02%
==========================================
Files 52 52
Lines 5587 5590 +3
Branches 852 853 +1
==========================================
+ Hits 4801 4805 +4
+ Misses 663 662 -1
Partials 123 123
|
michalk8
requested changes
Feb 15, 2023
michalk8
reviewed
Feb 15, 2023
|
thanks a lot Michal for the great comments, sorry for giving you extra work :) |
michalk8
approved these changes
Feb 15, 2023
michalk8
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ny regularization. (#286) * add primal_cost * precommit * avoid using unbalanced for LRSinkhorn * take comments into account. * bib * incorporating comments. * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
primal_costproperty to the output of a GW solver (regular and LR), solves #186