Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue of rtmp not being able to listen to ipv6, added ipv6 port verification code. #2157

Closed
wants to merge 2 commits into from

Conversation

hzt1234hf
Copy link

@hzt1234hf hzt1234hf commented Jan 20, 2021

Hello administrator, I recently fixed a small issue with listening to the rtmp IPv6 port. Please review.

  • Issue source: Issue Configuring Failed to Start IPV6
  • Issue: The original problem was mainly due to a slight difference in the listening method between IPv4 and IPv6 ports. For IPv4, it only needs to write the port number to listen, while for IPv6, it needs to write at least [::]:port to listen. Therefore, an error occurs during verification.
  • Modification: Added validation code for IPv6, currently only supports the format [::]:port.
  • Usage and effect: Modify the settings, start SRS, and after testing, it can correctly listen to the IPv6 port, and both pushing and pulling streams work normally.
    • image
    • image
    • image

TRANS_BY_GPT3

@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #2157 (5d86143) into 3.0release (4f01340) will decrease coverage by 0.00%.
The diff coverage is 58.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##           3.0release    #2157      +/-   ##
==============================================
- Coverage       52.91%   52.91%   -0.01%     
==============================================
  Files              82       82              
  Lines           26693    26703      +10     
==============================================
+ Hits            14125    14130       +5     
- Misses          12568    12573       +5     

| Impacted Files | Coverage Δ | |'

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_config.cpp | 81.07% <58.33%> (-0.12%) | ⬇️ |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f01340...5d86143. Read the comment docs.

TRANS_BY_GPT3

@winlinvip winlinvip force-pushed the 3.0release branch 27 times, most recently from af2f6bb to 3c0fc9b Compare August 15, 2021 09:07
@winlinvip winlinvip force-pushed the 3.0release branch 4 times, most recently from 1ca9308 to 8d44b98 Compare August 15, 2021 09:22
@winlinvip winlinvip self-requested a review August 27, 2021 00:14
@winlinvip winlinvip self-assigned this Aug 27, 2021
@winlinvip winlinvip modified the milestone: SRS 4.0 release Aug 27, 2021
@chen-guanghua
Copy link
Contributor

chen-guanghua commented Sep 5, 2021

#2581, the mentioned issue has been fixed.

TRANS_BY_GPT3

@winlinvip winlinvip changed the title 修复rtmp不能监听ipv6的问题,增加了ipv6端口验证代码 Fixed the issue of rtmp not being able to listen to ipv6, added ipv6 port verification code. Jul 29, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants