Build srt-1-fit fails with standard attributes in middle of decl-specifiers on GCC 12

[hashworks]

I'm currently trying to build the latest develop commit 29ae29c, but it fails with standard attributes in middle of decl-specifiers.

cd trunk
./configure
make

[ 37%] Building CXX object CMakeFiles/srt_virtual.dir/srtcore/api.cpp.o
In file included from trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/api.h:60,
                 from trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/api.cpp:60:
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/netinet_any.h: In constructor ‘sockaddr_any::sockaddr_any(int)’:
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/netinet_any.h:40:15: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘struct sockaddr_any’; use assignment or value-initialization instead [-Wclass-memaccess]
   40 |         memset(this, 0, sizeof *this);
      |         ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/netinet_any.h:28:8: note: ‘struct sockaddr_any’ declared here
   28 | struct sockaddr_any
      |        ^~~~~~~~~~~~
In file included from trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/udt.h:70,
                 from trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/api.h:61:
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/srt.h: At global scope:
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/srt.h:84:28: error: standard attributes in middle of decl-specifiers
   84 | #define SRT_ATR_DEPRECATED [[deprecated]]
      |                            ^
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/srt.h:198:9: note: in expansion of macro ‘SRT_ATR_DEPRECATED’
  198 | typedef SRT_ATR_DEPRECATED SRT_SOCKOPT SRT_SOCKOPT_DEPRECATED;
      |         ^~~~~~~~~~~~~~~~~~
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/srt.h:84:28: note: standard attributes must precede the decl-specifiers to apply to the declaration, or follow them to apply to the type
   84 | #define SRT_ATR_DEPRECATED [[deprecated]]
      |                            ^
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/srt.h:198:9: note: in expansion of macro ‘SRT_ATR_DEPRECATED’
  198 | typedef SRT_ATR_DEPRECATED SRT_SOCKOPT SRT_SOCKOPT_DEPRECATED;
      |         ^~~~~~~~~~~~~~~~~~
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/srt.h:84:28: warning: attribute ignored [-Wattributes]
   84 | #define SRT_ATR_DEPRECATED [[deprecated]]
      |                            ^
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/srt.h:198:9: note: in expansion of macro ‘SRT_ATR_DEPRECATED’
  198 | typedef SRT_ATR_DEPRECATED SRT_SOCKOPT SRT_SOCKOPT_DEPRECATED;
      |         ^~~~~~~~~~~~~~~~~~
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/srt.h:84:28: note: an attribute that appertains to a type-specifier is ignored
   84 | #define SRT_ATR_DEPRECATED [[deprecated]]
      |                            ^
trunk/objs/Platform-Linux-5.19.4-GCC12.2.0-SRS5-x86_64/srt-1-fit/srtcore/srt.h:198:9: note: in expansion of macro ‘SRT_ATR_DEPRECATED’
  198 | typedef SRT_ATR_DEPRECATED SRT_SOCKOPT SRT_SOCKOPT_DEPRECATED;
      |         ^~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/srt_virtual.dir/build.make:76: CMakeFiles/srt_virtual.dir/srtcore/api.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:113: CMakeFiles/srt_virtual.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
Build srt-1-fit failed, ret=2

I searched around a bit, it seems this is related to GCC 12. But I'm not a C++ developer, so take this with a grain of salt.

Any idea?

[hashworks]

https://www.gnu.org/software/gcc/gcc-12/changes.html

Stricter checking of attributes on friend declarations: if a friend declaration has an attribute, that declaration must be a definition. Moreover, a C++11 attribute cannot appear in the middle of the decl-specifier-seq. (PR99032)

[winlinvip]

Please file issue to SRT, not issue of SRS.

[hashworks]

@winlinvip it seems that the bug disappears with srt-1-fit v1.4.3 onwards (currently v1.4.1 is in the repo), I failed to test newer versions in my previous tests. Does anything speak against an update to v1.4.3 or even the latest stable v1.5.0?

[winlinvip]

We won't upgrade SRT for GCC 12 because it might cause other issues, but we might upgrade in future. So please test which version is ok and upgrade in your own SRS branch.