Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new ros3djs with CBOR PointCloud2 #12

Closed
wants to merge 2 commits into from

Conversation

mvollrath
Copy link
Contributor

Point to a chain of forks that results in latest roslibjs and ros3djs. Since this chain of forks is not ideal, we should work to get all of the affected packages released and bowers updated:

  • roslibjs
  • ros3djs
  • ros-websocket
  • ros-service
  • polymer-ros-rviz

Via a fork of polymer-ros-rviz.
@mvollrath mvollrath mentioned this pull request Jan 10, 2019
@chapulina
Copy link
Contributor

@mvollrath , mind keeping a list of all upstream PRs that need to be merged so this change can be reverted? The list can either stay on this PR or in a new issue in this repository.

@mvollrath
Copy link
Contributor Author

mvollrath commented Jan 10, 2019

Upstream things:
List moved to #13

@mvollrath
Copy link
Contributor Author

Added links to relevant PRs on the list.

@mvollrath
Copy link
Contributor Author

Moved the list to #13 so we can merge this and keep working.

@jubeira
Copy link
Collaborator

jubeira commented Jan 11, 2019

Just for the record, I tested the pointclouds and it seems to work well with the new cbor encoding 👍.

Some observations:

  • When I open the page in the browser I get a JS error in the console coming from scripts/STLLoader:
    TypeError: THREE.EventDispatcher.prototype.apply is not a function.
    Perhaps STL and Collada loaders have to be updated as well? These seem to be duplicates of the files that are in ros3djs repo.
  • Another thing I did notice is that there seems to be an issue with robot models; this is how I see PR2:
    screenshot from 2019-01-11 16-10-08
    perhaps this is related to the loaders as well. I don't see any JS error when I load it, just a bunch of logs.

bower.json Outdated
@@ -15,7 +15,7 @@
"tests"
],
"dependencies": {
"ros-rviz": "osrf/polymer-ros-rviz#master",
"ros-rviz": "EndPointCorp/polymer-ros-rviz#9c4061476657724fa8900a1ee973748e3781035d",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvollrath
Copy link
Contributor Author

Updated this PR to use the proposed ros3djs 1.0.0 with THREE r89 branch.

PointCloud2 show/hide is broken, due to a ros3djs interface change.

@jubeira
Copy link
Collaborator

jubeira commented Feb 22, 2019

Now that all the dependencies and upgrades are already merged in ros-rviz, ros-websocket and ros-service, we can just keep pointing to master.

Thanks @mvollrath!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants