chore: run cargo update across osmosis #8683
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this.... purposeful? Thanks! |
crnbarr93
reviewed
Sep 17, 2024
| @@ -74,7 +74,7 @@ jobs: | |||
| docker run --rm -v "$(pwd)":/code \ | |||
| --mount type=volume,source="$(basename "$(pwd)")_cache",target=/code/target \ | |||
| --mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \ | |||
| cosmwasm/workspace-optimizer:0.12.10 | |||
| cosmwasm/workspace-optimizer:0.16.0 | |||
There was a problem hiding this comment.
I have a feeling this will fail for some of the contracts in /cosmwasm. I tried updating this here and it failed, trying it locally also failed.
Updating the other contracts (in some fashion) may require a separate PR to make this work.
crnbarr93
reviewed
Sep 17, 2024
| @@ -31,27 +34,27 @@ imported = [] | |||
| optimize = """docker run --rm -v "$(pwd)":/code \ | |||
| --mount type=volume,source="$(basename "$(pwd)")_cache",target=/code/target \ | |||
| --mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \ | |||
| cosmwasm/rust-optimizer:0.12.11 | |||
| cosmwasm/rust-optimizer:0.16.0 | |||
There was a problem hiding this comment.
nit: We can probably swap these to just use cosmwasm/optimizer:0.16.0 instead of rust/workspace-optimizer as in the docs
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Run cargo update across all of the Rust code in Osmosis.
Testing and Verifying
This change is already covered by existing tests, and should be closed if it doesn't pass tests, or doesn't make sense to the maintainers.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md? yes, shortlyWhere is the change documented?
x/{module}/README.md)