Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all proto structs to use strings for addresses #165

Merged
merged 4 commits into from
May 8, 2021

Conversation

sunnya97
Copy link
Collaborator

@sunnya97 sunnya97 commented May 8, 2021

closes #121

@sunnya97 sunnya97 added T:code-hygiene C:gRPC Issues and PRs related to the gRPC service and HTTP gateway. proto-breaking Protobuf breaking changes: generally don't do this! labels May 8, 2021
@sunnya97 sunnya97 requested a review from ValarDragon May 8, 2021 00:01
x/lockup/types/msgs.go Outdated Show resolved Hide resolved
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we remove nolint:interfacer

@sunnya97 sunnya97 merged commit 0816d81 into main May 8, 2021
@sunnya97 sunnya97 deleted the sunny/proto-address-strings branch May 8, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:gRPC Issues and PRs related to the gRPC service and HTTP gateway. proto-breaking Protobuf breaking changes: generally don't do this! T:code-hygiene
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Switch Addresses in proto files from bytes to string
2 participants