Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle zero max cap #192

Merged
merged 16 commits into from
Sep 5, 2024
Merged

Conversation

trinitys7
Copy link
Collaborator

@trinitys7 trinitys7 commented Jul 2, 2024

Close #100
Due to virtual staking and converter contract does not have delegator info, we need to resend the msg to external staking contract.

After external staking is called via ibc, converter contract get the Ack message, if it success, a msg to virtual staking contract will be executed to unbond the given amount by delegator.

@trinitys7 trinitys7 marked this pull request as draft July 2, 2024 08:04
@JakeHartnell
Copy link
Collaborator

Needs cargo fmt to fix linting errors.

Copy link
Collaborator

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments mostly around documentation and cleaning up TODOs.

@vuong177 vuong177 merged commit 84d6b2a into osmosis-labs:main Sep 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual staking zero max-cap behaviour
3 participants