New Permission Check implementation #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user experience. The new method will correctly ask for both permissions on first launch. (Former version was only asked one permission per session.)
|
despite the travis failures, i'm going to merge it. the failures are not code or test related. |
spyhunter99
added a commit
that referenced
this pull request
Jan 5, 2016
New Permission Check implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former permission check implementation only checked for a single permission for each session. This new implementation will request both permissions on first launch. Additionally, I improved the workflow for a better user experience with an initial Toast to explain why they are being prompted for the permission.
Commit is a bit confusing. I moved the ListView choice selection to the top, and rewrote both permission methods from scratch.
Travis CI states the build is passing