Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise project outputs to AAR #146

Closed
spyhunter99 opened this issue Aug 8, 2015 · 6 comments
Closed

Revise project outputs to AAR #146

spyhunter99 opened this issue Aug 8, 2015 · 6 comments

Comments

@spyhunter99
Copy link
Collaborator

convert to AAR format
remove slf4j
remove the ResourceProxy (save this for rainy day)

@spyhunter99
Copy link
Collaborator Author

@neilboyd if you want to remove sfl4j, what do you want to use instead? or just the standard android logcat?

@neilboyd
Copy link
Contributor

neilboyd commented Aug 9, 2015

My idea was to use standard Android logging. I haven't thought this through, but isn't it part of the same story about using real Android resources? And using something like Robolectric? Or is Robolectric redundant now?

@spyhunter99
Copy link
Collaborator Author

alright, i'm on it. i already have the aar part done and tested.

@spyhunter99
Copy link
Collaborator Author

@neilboyd i'll throw this over to you for the resource proxy stuff. this will probably be a breaking change.

@neilboyd
Copy link
Contributor

@spyhunter99 I wasn't planning on working on this now.

I thought it was a relatively small change that becomes possible by using AAR format, but if you don't want to do it then you can make a new issue that I'll look at some time in the future.

@spyhunter99
Copy link
Collaborator Author

OK, we can revise this ticket to exclude the removal of the resource proxy and save it for another day

spyhunter99 added a commit that referenced this issue Oct 3, 2015
* my_fork/#146:
  #146 fixes integration tests and uses a single constant for logging
  #146 removing sfl4j
  #146 convert to war output
spyhunter99 added a commit that referenced this issue Oct 3, 2015
#146 removing sfl4j and using aar as the output
spyhunter99 added a commit that referenced this issue Oct 9, 2015
* master: (67 commits)
  #99 ability to change my location icon after creation.
  #158 partial resolution for android 6
  #112 found an alternative to keep the min sdk at 7
  #112 patch for x86 android builds that do not correctly return isAvailable on ethernet, checks for ethernet && x86 build
  merging the fix for 158, android 6 support
  NullPointerException: TilesOverlay.java line 328 #157
  updating the build tech
  revising the build tech for android studio support
  adding night mode to the example app
  minor javadoc edits
  updating dependencies based on android's sdks updated
  Revert "compile fix (remove deprecated methods)"
  compile fix (remove deprecated methods)
  Update README.md
  #146 fixes integration tests and uses a single constant for logging
  #146 removing sfl4j
  #146 convert to war output
  #140 adding the basics for user selectable offline map sources (instead of everything goes)
  135 changing sqlite access to readonly to help support android versions (kitkat) that blocks write access to external sdcards
  133 night mode
  ...

# Conflicts:
#	osmdroid-android/src/main/java/org/osmdroid/api/IMapController.java
#	osmdroid-android/src/main/java/org/osmdroid/contributor/RouteRecorder.java
#	osmdroid-android/src/main/java/org/osmdroid/contributor/util/RecordedGeoPoint.java
#	osmdroid-android/src/main/java/org/osmdroid/contributor/util/Util.java
#	osmdroid-android/src/main/java/org/osmdroid/views/MapController.java
#	osmdroid-android/src/main/java/org/osmdroid/views/MapView.java
#	osmdroid-android/src/main/java/org/osmdroid/views/Projection.java
spyhunter99 pushed a commit that referenced this issue Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants