Add support for node processing in second stage #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joto
force-pushed
the
two-stage-proc-nodes
branch
from
0684645
to
a8ab3fc
Compare
lonvia
reviewed
Sep 18, 2024
flex-config/public-transport.lua
Outdated
| -- Nodes tagged as public transport stops are imported into the 'stops' table, | ||
| -- ways tagged as highway or railway or imported into the 'lines' table. The | ||
| -- public transport routes themselves will be in the 'routes' table, but | ||
| -- without any geomtry. As a "bonus" public transport stop area relations |
flex-config/public-transport.lua
Outdated
| end | ||
|
|
||
| function osm2pgsql.process_node(object) | ||
| -- Wer are only interested in public transport stops here, and they are |
This is completely analog to how way processing happens in the second stage. So from the select_relation_member() function in the Lua config file you can now also return a list of nodes that you request to process again. Note that this will only re-process the member nodes themselves, ways which have these nodes as members are not re-processed. Also there is no way to mark member nodes of ways, only member nodes of relations. So this will allow processing, say, stop positions in public transport route relations but not, say, barriers on roads. This change is now possible because we removed support for the old middle format which didn't allow storing the complete nodes (with tags).
joto
force-pushed
the
two-stage-proc-nodes
branch
from
a8ab3fc
to
3d52ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is completely analog to how way processing happens in the second stage. So from the select_relation_member() function in the Lua config file you can now also return a list of nodes that you request to process again.
Note that this will only re-process the member nodes themselves, ways which have these nodes as members are not re-processed. Also there is no way to mark member nodes of ways, only member nodes of relations. So this will allow processing, say, stop positions in public transport route relations but not, say, barriers on roads.
This change is now possible because we removed support for the old middle format which didn't allow storing the complete nodes (with tags).