Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove PORT from nodemon envs #313

Merged
merged 1 commit into from
Jan 5, 2024
Merged

chore: remove PORT from nodemon envs #313

merged 1 commit into from
Jan 5, 2024

Conversation

jonas-jonas
Copy link
Member

Seems like adding that breaks Kratos e2e tests, somehow... This should fix the tests for now. cc @hperl

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Jan 5, 2024
@jonas-jonas jonas-jonas requested a review from hperl January 5, 2024 12:18
Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Yes, I committed this on accident.

@hperl hperl merged commit 02e9448 into master Jan 5, 2024
9 checks passed
@hperl hperl deleted the jonas-jonas/fixPort branch January 5, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants