Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Doctrine ORM to 2.5.4. #502

Closed
wants to merge 1 commit into from

Conversation

mathop
Copy link

@mathop mathop commented Jul 15, 2016

The current Doctrine ORM version (2.5.1) doesn't work with PHP 7 type hints, it was fixed in the version 2.5.3.

DDC-4019: Proxy generator is not including PHP7 return type hints

@orocla
Copy link

orocla commented Jul 15, 2016

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for some time for the submission to be processed.

@mkudelya
Copy link
Contributor

mkudelya commented Feb 7, 2017

2.0 version of platform is already contains 2.5.5 version of doctrine/orm.
Thank you!

@mkudelya mkudelya closed this Feb 7, 2017
@dewos
Copy link

dewos commented May 18, 2018

@mkudelya Any chance to add this also to the 1.10 branch?

@anyt
Copy link
Contributor

anyt commented May 18, 2018

1.10 compatible with PHP 7.0 so issue above should not be a problem there.

As I know It is not planned yet to upgrade Doctrine ORM to 1.10. But even if it will be implemented you should know that for Community Edition we provide patch updates only for the latest LTS version, currently, this is 2.6 LTS. So even if an update will be scheduled it will be done only on Enterprise version.

@dewos
Copy link

dewos commented Jun 1, 2018

1.10 is compatible with PHP 7.0, but doctrine/orm 2.5.1 is not (for type-hint).

@anyt
Copy link
Contributor

anyt commented Jun 1, 2018

yes, it doesn't support new features, but if you'll not use type-hint with php 7.0 this will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants