-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Target #80
Memory Target #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7eb1375
to
6107b1b
Compare
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
6107b1b
to
1d8e0a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I compared it to what we have, I think I rather like how this is structured. I spent some time on the internal structure, but mostly seeing functionality via the good tests.
I was going to merge this in, but don't know if you are ready for it @shizhMSFT . |
@deitch I'm ready to merge it. |
oras.Copy()
using theMemory
target.