Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump github.com/opencontainers/image-spec to v1.1.0-rc5 #615

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

Wwwsylvia
Copy link
Member

  1. Bump github.com/opencontainers/image-spec to v1.1.0-rc5 in go mod
  2. Replace "index.json" and "blobs" with corresponding constants in the spec
  3. Fix testable examples that broke by the spec change - MediaType became a required field in Descriptor

Resolve: #599

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #615 (05530e9) into main (6dfbe52) will not change coverage.
The diff coverage is 75.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files          58       58           
  Lines        5313     5313           
=======================================
  Hits         3963     3963           
  Misses        995      995           
  Partials      355      355           
Files Coverage Δ
content/oci/readonlyoci.go 73.52% <100.00%> (ø)
content/oci/readonlystorage.go 87.50% <100.00%> (ø)
content/oci/oci.go 75.28% <50.00%> (ø)

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 86176e8 into oras-project:main Oct 12, 2023
7 checks passed
@Wwwsylvia Wwwsylvia deleted the spec_rc5 branch October 12, 2023 06:59
Wwwsylvia added a commit to Wwwsylvia/oras-go that referenced this pull request Oct 19, 2023
…ras-project#615)

1. Bump `github.com/opencontainers/image-spec` to `v1.1.0-rc5` in go mod
2. Replace "index.json" and "blobs" with corresponding constants in the
spec
3. Fix testable examples that broke by the spec change - `MediaType`
became a required field in `Descriptor`

Resolve: oras-project#599
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
shizhMSFT pushed a commit that referenced this pull request Oct 20, 2023
)

1. Bump `github.com/opencontainers/image-spec` to `v1.1.0-rc5` in go mod
2. Replace "index.json" and "blobs" with corresponding constants in the
spec
3. Fix testable examples that broke by the spec change - `MediaType`
became a required field in `Descriptor`

Resolve: #599
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia mentioned this pull request Oct 20, 2023
4 tasks
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to image-spec v1.1.0-rc5
3 participants