Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add special handling for "docker.io" in StaticCredential() #504

Merged
merged 3 commits into from
May 10, 2023

Conversation

Wwwsylvia
Copy link
Member

Fixes #484

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #504 (61c7243) into main (c083b73) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   73.18%   73.22%   +0.03%     
==========================================
  Files          49       49              
  Lines        4595     4601       +6     
==========================================
+ Hits         3363     3369       +6     
  Misses        923      923              
  Partials      309      309              
Impacted Files Coverage Δ
registry/remote/auth/client.go 73.12% <100.00%> (+0.65%) ⬆️

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 0e20275 into oras-project:main May 10, 2023
@Wwwsylvia Wwwsylvia deleted the fix_static_cred branch May 10, 2023 08:53
@Wwwsylvia Wwwsylvia mentioned this pull request May 24, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: auth.StaticCredential does not properly handle docker.io
3 participants