fix: avoid copying Repository mutex state

[abursavich]

The Repository struct contains mutex state (in the sync.Mutex and syncutil.Pool). When converting RepositoryOptions values to Repository values, this mutex state is copied. This change prevents the internal state from being copied by passing RepositoryOptions around by reference and explicitly copying the visible fields.

[abursavich]

I considered also copying the referrersState, but I ultimately decided against it since RepositoryOptions blocks the methods on Repository that can mutate it.

[Wwwsylvia]

The Repository struct contains mutex state (in the sync.Mutex and syncutil.Pool). When converting RepositoryOptions values to Repository values, this mutex state is copied.

Nice catch!

[codecov-commenter]

Codecov Report

Merging #364 (ae08840) into main (f09c857) will increase coverage by 0.06%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   72.16%   72.22%   +0.06%     
==========================================
  Files          42       42              
  Lines        4092     4105      +13     
==========================================
+ Hits         2953     2965      +12     
- Misses        857      858       +1     
  Partials      282      282              

Impacted Files	Coverage Δ
registry/remote/repository.go	68.56% <77.77%> (+0.17%)	⬆️
registry/remote/registry.go	67.41% <100.00%> (+1.45%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[shizhMSFT]

@abursavich Thank you for your contribution and catching this bug. Could you address the review comments accordingly so that we can merged your PR?

[abursavich]

@shizhMSFT, PTAL.

[shizhMSFT]

LGTM

[abursavich]

PTAL

[Wwwsylvia]

LGTM

[shizhMSFT]

LGTM