Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

created an example of pushing reference manifest #172

Merged
merged 8 commits into from
Jun 21, 2022
Merged

created an example of pushing reference manifest #172

merged 8 commits into from
Jun 21, 2022

Conversation

wangxiaoxuan273
Copy link
Contributor

Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com

Part of Issue #60

@wangxiaoxuan273
Copy link
Contributor Author

I did not use oras.Copy() for this example, as I think I'll save it for the "Copy reference" example and oras.Fetch() looks decent for this one.

@shizhMSFT shizhMSFT requested a review from Wwwsylvia June 9, 2022 05:54
qweeah
qweeah reviewed Jun 9, 2022
View reviewed changes
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Show resolved Hide resolved
Wwwsylvia
Wwwsylvia reviewed Jun 14, 2022
View reviewed changes
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Jun 16, 2022
View reviewed changes
registry/remote/example_test.go Outdated Show resolved Hide resolved
registry/remote/example_test.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxiaoxuan273 @shizhMSFT
created an example of pushing reference manifest
a0dacbd 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273 @shizhMSFT
removed the duplicate reference of go-digest
2c8255a 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273 @shizhMSFT
changed mediatype of descriptors, according to the comments
4cfded4 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273 @shizhMSFT
addressed the comments
3a0b6e8 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273 @shizhMSFT
addressed the comments
6a1ab4e 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273 @shizhMSFT
addressed the final comment
4733c3e 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273 @shizhMSFT
updated descriptors
c63caa8 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273 @shizhMSFT
changed package name
b4e1654 
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@shizhMSFT shizhMSFT merged commit 1442208 into oras-project:main Jun 21, 2022
@wangxiaoxuan273 wangxiaoxuan273 deleted the examples branch June 23, 2022 08:03
@wangxiaoxuan273
Copy link
Contributor Author

Part of issue #178

@wangxiaoxuan273 wangxiaoxuan273 mentioned this pull request Jul 4, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qweeah qweeah qweeah left review comments

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@Wwwsylvia Wwwsylvia Awaiting requested review from Wwwsylvia Wwwsylvia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangxiaoxuan273 @qweeah @Wwwsylvia @shizhMSFT