Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #5195: using viewLifecycleOwner #5207

Merged
merged 8 commits into from
Oct 29, 2023
Merged

Fix part of #5195: using viewLifecycleOwner #5207

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9a09f9e
Modify subscribeToCurrentQuestion() function
sichchurov Oct 24, 2023
57f601f
Merge branch 'develop' into issue#5195_lifecycleowner_fixing
sichchurov Oct 24, 2023
90b823c
edit handleCreateView() in
sichchurov Oct 25, 2023
b7ab650
Merge remote-tracking branch 'upstream/develop' into issue#5195_lifec…
sichchurov Oct 25, 2023
ac48ba0
Merge branch 'issue#5195_lifecycleowner_fixing' of https://github.com…
sichchurov Oct 25, 2023
e3fcfb2
rollback to initial state QuestionPlayerFragmentPresenter
sichchurov Oct 26, 2023
1d408ee
use viewLifecycleOwner in subscribeToCurrentQuestion()
sichchurov Oct 29, 2023
f2eac9d
Merge branch 'develop' into issue#5195_lifecycleowner_fixing
sichchurov Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/src/main/java/org/oppia/android/app/survey/SurveyFragmentPresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,10 @@ class SurveyFragmentPresenter @Inject constructor(

private fun subscribeToCurrentQuestion() {
ephemeralQuestionLiveData.observe(
fragment,
{
processEphemeralQuestionResult(it)
}
)
fragment.viewLifecycleOwner
) {
processEphemeralQuestionResult(it)
}
}

private fun processEphemeralQuestionResult(result: AsyncResult<EphemeralSurveyQuestion>) {
Expand Down
Loading