-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MissingDefaultResource + AppCompatCustomView + FragmentTagUsage #5186
Comments
./gradlew :app:lint
@adhiamboperes I have resolved the FragmentTagUsage issue |
Hi @sichchurov, Please look into those issues which are not assigned to anyone. |
…gUsage (#5191) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> Fixes #5186 [part of #5169] 1. `MissingDefaultResource` has been fixed already by #5172. It had issues with these plurals: - [minutes_ago](https://github.com/oppia/oppia-android/blob/e060e2ff265ce35c92f1b969f6d7ad002d1a62ad/app/src/main/res/values/strings.xml#L456) - [hours_ago](https://github.com/oppia/oppia-android/blob/e060e2ff265ce35c92f1b969f6d7ad002d1a62ad/app/src/main/res/values/strings.xml#L461C18-L461C27) - [days_ago](https://github.com/oppia/oppia-android/blob/e060e2ff265ce35c92f1b969f6d7ad002d1a62ad/app/src/main/res/values/strings.xml#L465C18-L465C26) 3. For `AppCompatCustomView`, it is fixed by replacing the Normal views with AppCompat views 4. `<fragment/>` tags are replaced with `<androidx.fragment.app.FragmentContainerView/>`, with some changes in the NavigationDrawerFragment to ensure that binding has been initialized before it is accessed. ## Screen Recording https://github.com/oppia/oppia-android/assets/84731134/3a340cff-70a4-4e77-a1a3-e5b7a8c71a6e ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). <br> --------- Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
#5191 was reverted, so this is no longer fixed. |
@BenHenning ./gradlew :app:lint , this command always resulted in errors. |
Unassigning myself, as this can be a good first issue for new contributors. |
Description
We would like to fix all the remaining lint issues on Oppia Android in the "MissingDefaultResource + AppCompatCustomView + FragmentTagUsage" category.
Steps To Reproduce
Run the following command from a terminal in a checked-out Oppia Android repo:
./gradlew :app:lint
Output:
Expected Behavior
Running the command above should not show any errors.
The text was updated successfully, but these errors were encountered: