Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[53809] Update PageHeaders & SubHeaders in the (rails) global index pages (fix issues) #16882

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

bsatarnejad
Copy link
Contributor

@bsatarnejad bsatarnejad commented Oct 2, 2024

Ticket

https://community.openproject.org/projects/design-system/work_packages/53809/activity

What are you trying to accomplish?

Fix remaining issues from previous PR: Breadcrumbs correction in Home, Meetings, Time and costs pages, use Primer button for adding a new board, calendar, team planner.

Screenshots

Before:
Screenshot 2024-10-02 at 10 26 21

After:
Screenshot 2024-10-02 at 10 26 45

Before:
Screenshot 2024-10-02 at 10 25 24

After:
Screenshot 2024-10-02 at 10 25 36

Before:
Screenshot 2024-10-02 at 10 24 53

After:
Screenshot 2024-10-02 at 10 25 05

Before:
Screenshot 2024-10-02 at 10 22 52

After:
Screenshot 2024-10-02 at 10 23 30

What approach did you choose and why?

Use Primer button for creating a new board, calendar, team planner and fix breadcrumbs.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant