[#57814] added predicate for field_format

opf · Oct 1, 2024 · 6fdbc59 · 6fdbc59
1 parent e0097af
commit 6fdbc59
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/app/models/custom_field.rb b/app/models/custom_field.rb
@@ -293,6 +293,10 @@ def multi_value_possible?
     version? || user? || list?
   end
 
+  def field_format_hierarchy?
+    field_format == "hierarchy"
+  end
+
   def allow_non_open_versions_possible?
     version?
   end

diff --git a/app/services/custom_fields/create_service.rb b/app/services/custom_fields/create_service.rb
@@ -56,7 +56,7 @@ def after_perform(call)
 
       if cf.is_a?(ProjectCustomField)
         add_cf_to_visible_columns(cf)
-      elsif cf.field_format == "hierarchy"
+      elsif cf.field_format_hierarchy?
         # TODO: Use persistence service
         CustomField::Hierarchy::Item.create(custom_field: cf,
                                             label: nil,

diff --git a/app/views/custom_fields/edit.html.erb b/app/views/custom_fields/edit.html.erb
@@ -33,7 +33,7 @@ See COPYRIGHT and LICENSE files for more details.
 
 <%= error_messages_for 'custom_field' %>
 
-<% if @custom_field.field_format == "hierarchy" %>
+<% if @custom_field.field_format_hierarchy? %>
   <%= render CustomFields::DetailsComponent.new(@custom_field) %>
 <% else %>
   <%= labelled_tabular_form_for @custom_field, as: :custom_field,