fix: merge existing and extra fbc while rendering the index image #6512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everettraven
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Thanks for taking the time to make this contribution @iamniting ! These changes look good to me!
/lgtm
rashmigottipati
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Thanks for your contribution @iamniting, changes look good to me.
/lgtm
rashmigottipati
requested changes
Jul 25, 2023
copy the FBC of index-image as well if --index-image is passed to the operator-sdk run bundle command Fixes operator-framework#6505 Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
I added it, Can you pls take a look and see if it is good enough or shall I make it more descriptive? |
rashmigottipati
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
During the creation of a new catalog image using the operator-sdk, a critical bug was identified where existing FBC (File-Based Configuration) files were not being copied to the new location of the catalog image. Consequently, the generated catalog image was missing essential FBC files, leading to incorrect behavior and potential issues for end-users.
This bug fix addresses the root cause of the problem by ensuring that both the old and new FBC files are correctly included in the catalog image creation process. With this fix, the resulting catalog image will contain all the necessary FBC files, thereby resolving the issue of missing configurations and ensuring the operator functions as expected. Users can now rely on the updated catalog image to access and utilize the complete set of FBC files, enhancing the overall stability and reliability of the operator-sdk.
Motivation for the change:
Fix: #6505
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs