Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add view rbac to 'admin' and 'edit' default roles #671

Merged
merged 4 commits into from
Mar 1, 2019
Merged

add view rbac to 'admin' and 'edit' default roles #671

merged 4 commits into from
Mar 1, 2019

Conversation

aweiteka
Copy link
Contributor

@aweiteka aweiteka commented Jan 16, 2019 •
edited
Loading

Project admins can create/update/delete objects but cannot get/list/watch them. This allows OLM to work as expected for users who are not cluster-admins.

Signed-off-by: Aaron Weitekamp aweiteka@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2019
@madorn
Copy link
Member

madorn commented Jan 17, 2019

I was able to replicate the issue and confirm provided fix.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2019
alecmerdler
alecmerdler requested changes Jan 31, 2019
View reviewed changes
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aweiteka We're actually going to want this change made to this file so it applies to all future releases.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2019
@aweiteka
Copy link
Contributor Author

related to #673

@aweiteka
Copy link
Contributor Author

@aweiteka We're actually going to want this change made to this file so it applies to all future releases.

PR updated with that file.

@alecmerdler
Copy link
Member

Can you please remove the changes to the 0.7.1 files.

@openshift-ci-robot
Copy link
Collaborator

@openshift-bot: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@aweiteka: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@aweiteka: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test e2e-aws-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2019
@alecmerdler
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 14, 2019
@operator-framework operator-framework deleted a comment from aweiteka Feb 14, 2019
@operator-framework operator-framework deleted a comment from aweiteka Feb 14, 2019
@aweiteka
Copy link
Contributor Author

/test e2e-aws

@aweiteka
Copy link
Contributor Author

/test e2e-aws-olm

@njhale
Copy link
Member

njhale commented Feb 21, 2019

@aweiteka Thanks for adding this! Could you run make release to have the changes reflected in our release manifests? Also please remove the changes to 0.7.1 manifests.

@aweiteka
Copy link
Contributor Author

@ecordell thanks for the commit.

@ecordell
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aweiteka, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@ecordell
Copy link
Member

/retest

1 similar comment
@aweiteka
Copy link
Contributor Author

aweiteka commented Mar 1, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 04d2513 into operator-framework:master Mar 1, 2019
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@openshift-merge-robot
Merge pull request operator-framework#671 from aweiteka/rbac
3c78527 
add view rbac to 'admin' and 'edit' default roles
@njhale njhale added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler alecmerdler requested changes

@ecordell ecordell Awaiting requested review from ecordell

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aweiteka @madorn @alecmerdler @openshift-ci-robot @njhale @ecordell @openshift-merge-robot