Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next (v5) (DO NOT MERGE) #2203

Open
wants to merge 81 commits into
base: main
Choose a base branch
from
Open

next (v5) (DO NOT MERGE) #2203

wants to merge 81 commits into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jan 18, 2024

No description provided.

@csviri csviri force-pushed the next branch 2 times, most recently from f8441d9 to b2caf28 Compare January 25, 2024 10:32
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 5, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
@metacosm metacosm force-pushed the next branch 2 times, most recently from d7da94e to 76046f7 Compare April 11, 2024 14:50
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2024
@csviri csviri force-pushed the next branch 2 times, most recently from afe3d7d to cc57156 Compare May 21, 2024 19:03
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 17, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 8, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
csviri and others added 24 commits September 20, 2024 09:00
@csviri
docs: use docs dir instead of docsy (#2443)
afc7aa5 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: move getResourceClassResolver to BaseConfigurationService (#…
ffef582 
…2451)

The class resolving mechanism is only needed in that class right now

Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri @metacosm
feat: @ControllerConfiguration annotation is optional (#2412)
ec6a085 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@csviri
bump: chore use slf4j v2 (#2406)
690ad52 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: integration test to show multiple dependents with activation co…
a76dd92 
…ndition (#2454)


Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
refactor: updateMatcher removal (#2431)
a59f3e5
@metacosm @csviri
chore(docs): add some javadoc (#2452)
e3e3805 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
fix: improper use of @link (#2464)
88b2b98 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
feat: move controller informer-related configuration to InformerConfig (
0b94a17 
#2455)

* feat: move controller informer-related configuration to InformerConfig

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: start isolating ResourceConfiguration

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: initFromAnnotation now properly inits the current instance

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: default onDeleteFilter implementation

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: properly set default namespaces in controller case

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: remove KubernetesDependentInformerConfigBuilder

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: use InformerConfigHolder in more places, unifying handling

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: properly propagate name to informer config

Signed-off-by: Chris Laprun <claprun@redhat.com>

* feat: add factory method to init builder from an extising configuation

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: remove potentially problematic default implementation

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
feat: allow returning additional information from conditions (#2426)
3acabda 
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
@10000-ki @csviri
feat: support for graceful shutdown based on configuration (#2479)
0fe4ebc 
---------

Signed-off-by: 10000-ki <10000ki6472@gmail.com>
@csviri @metacosm
refactor: move integration tests to feature packages and sub packages…
faab507 
… based on type (#2483)

* refactor: integration tests moved to feature packages and sub packages pased on type

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* fix resource paths

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* fixes

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* link and test fixes

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* format

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* wip

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* old service

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* test fix

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* refactor: remove unneeded classes

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: typo in package name

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
refactor: clean up informer configuration classes (#2470)
b009b9c 
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* fix: format after rebase

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <claprun@redhat.com>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: pom format after rebase
ee7fbee 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
improve: replace jenvtest with kube-api-test from fabric8 client (#2497)
fe995a0 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
8432449 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
@metacosm @csviri
refactor: clean up ResourceConfiguration & rename to Informable (#2486)
08b6425 
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
@csviri @metacosm
feat: support to handle different cluster for InformerEventSource (#2499
240bf03 
)



Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@matteriben @csviri
chore: update comment to reflect change in interface (#2512)
7149bbc 
Signed-off-by: Matt Riben <matt.riben@swirldslabs.com>
@metacosm @csviri
chore: adapt after rebase
7e907fc 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
fix: wrong return type
35cc48d 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
improve: cleaner throws Exception (#2527)
8457720 

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@metacosm @csviri
feat: explicit node configuration in WorkflowBuilder (#2511)
80842fd 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
fix: cleanup after rebase on main
fd45078 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
@csviri
feat: context getSecondary resource is activation condition aware (#2532
8039ef0 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
feat: e2e test to demonstrate namespace deletion problem fix (#2528)
1635c9e 

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

@metacosm metacosm Awaiting requested review from metacosm

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csviri @openshift-merge-robot @metacosm @10000-ki @matteriben