Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drops internal DependencyLinkSpan for Span2 #1673

Merged
merged 3 commits into from
Jul 28, 2017
Merged

Drops internal DependencyLinkSpan for Span2 #1673

merged 3 commits into from
Jul 28, 2017

Commits on Jul 28, 2017

  1. Adds zipkin.internal.Span2Converter (#1670) 

    This adds an internal copy of a span conversion utility mentioned in
issue #1499. This is starting internal to ease review and allow
incremental progress. The first consumer will be dependency linking.
    @adriancole
    adriancole committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    e58e3a8 View commit details
    Browse the repository at this point in the history

  2. Adds zipkin.internal.Span2Codec.JSON (#1671) 

    This adds an internal copy of a span json codec issue #1499. This starts
internal to ease review and allow incremental progress. The first
consumer will be Elasticsearch, as this format removes nested queries.

Note: this change also introduces json serialization of Span2, which
allows future use in Spark.
    @adriancole
    adriancole committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    998f50d View commit details
    Browse the repository at this point in the history

  3. Drops internal DependencyLinkSpan for Span2 

    This drops the internal type of DependencyLinkSpan in favor of the Span2
type coming in #1499. Doing so now gives us practice, solves a few bugs
along the way. When Span2 becomes non-internal, the change will be a
simple package rename.
    Adrian Cole committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    d977317 View commit details
    Browse the repository at this point in the history