Clean-up duplicate functions from pass dir (#2553)

use PassUtil instead
openxla · Sep 19, 2024 · 376dbf3 · 376dbf3
1 parent 449d276
commit 376dbf3
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 12 deletions.
diff --git a/stablehlo/transforms/PassUtils.cpp b/stablehlo/transforms/PassUtils.cpp
@@ -30,5 +30,11 @@ Value getConstantLike(OpBuilder &b, Location loc, const APFloat &constant,
                                               val);
 }
 
+bool isAnyQuantizedTypes(TypeRange types) {
+  return llvm::any_of(types, [](Type type) {
+    return isa<quant::QuantizedType>(getElementTypeOrSelf(type));
+  });
+}
+
 }  // namespace stablehlo
 }  // namespace mlir
diff --git a/stablehlo/transforms/PassUtils.h b/stablehlo/transforms/PassUtils.h
@@ -51,6 +51,9 @@ Value getConstantLike(OpBuilder &b, Location loc, T constant, Value val) {
 Value getConstantLike(OpBuilder &b, Location loc, const APFloat &constant,
                       Value val);
 
+// Check if any of the given types are mlir::quant::QuantizedType.
+bool isAnyQuantizedTypes(TypeRange types);
+
 }  // namespace stablehlo
 }  // namespace mlir
 

diff --git a/stablehlo/transforms/StablehloLegalizeQDQToQuantizedOp.cpp b/stablehlo/transforms/StablehloLegalizeQDQToQuantizedOp.cpp
@@ -21,6 +21,7 @@ limitations under the License.
 #include "mlir/Transforms/DialectConversion.h"  // Include for TypeConverter
 #include "mlir/Transforms/GreedyPatternRewriteDriver.h"
 #include "stablehlo/dialect/StablehloOps.h"
+#include "stablehlo/transforms/PassUtils.h"
 #include "stablehlo/transforms/Passes.h"
 
 namespace mlir {
@@ -31,12 +32,6 @@ namespace stablehlo {
 
 namespace {
 
-bool isAnyQuantizedTypes(TypeRange types) {
-  return llvm::any_of(types, [](Type type) {
-    return isa<quant::QuantizedType>(getElementTypeOrSelf(type));
-  });
-}
-
 struct QuantizedStablehloQDQToQuantizedOpConversion
     : public OpRewritePattern<stablehlo::UniformQuantizeOp> {
   using OpRewritePattern<stablehlo::UniformQuantizeOp>::OpRewritePattern;

diff --git a/stablehlo/transforms/StablehloLegalizeQuantizedOpToQDQ.cpp b/stablehlo/transforms/StablehloLegalizeQuantizedOpToQDQ.cpp
@@ -28,6 +28,7 @@ limitations under the License.
 #include "mlir/Transforms/DialectConversion.h"  // Include for TypeConverter
 #include "mlir/Transforms/GreedyPatternRewriteDriver.h"
 #include "stablehlo/dialect/StablehloOps.h"
+#include "stablehlo/transforms/PassUtils.h"
 #include "stablehlo/transforms/Passes.h"
 
 namespace mlir {
@@ -38,12 +39,6 @@ namespace stablehlo {
 
 namespace {
 
-bool isAnyQuantizedTypes(TypeRange types) {
-  return llvm::any_of(types, [](Type type) {
-    return isa<quant::QuantizedType>(getElementTypeOrSelf(type));
-  });
-}
-
 // Gets the QuantizedType associated with the given type, or returns failure if
 // not quantized.
 FailureOr<quant::QuantizedType> getQuantType(Type type) {