bugfix: handling null #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
lukasjhan
requested review from
zustkeeper and
berendsliedrecht
as code owners
lukasjhan
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 65.57% 65.57%
=======================================
Files 33 33
Lines 2115 2115
Branches 234 234
=======================================
Hits 1387 1387
Misses 709 709
Partials 19 19 ☔ View full report in Codecov by Sentry. |
berendsliedrecht
approved these changes
Feb 22, 2024
cre8
pushed a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com> Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8
pushed a commit
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com> Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i
f (obj instanceof Object)is changed toif (typeof obj === 'object')in #80if obj is
null, the first statement is false, but second one is trueSo I added the checking logic.