Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate JWT signed other implemenation #158

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

lukasjhan
Copy link
Member

@lukasjhan lukasjhan commented Mar 11, 2024

I added private field in JWT class. It is set when we created JWT instance from encoded.
And I created getUnsignedToken method to use encoded jwt string when it is existed.

It close #157

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (d9eaf44) to head (982a06a).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #158      +/-   ##
==========================================
+ Coverage   97.81%   98.03%   +0.21%     
==========================================
  Files          23       23              
  Lines        2062     2082      +20     
  Branches      295      307      +12     
==========================================
+ Hits         2017     2041      +24     
+ Misses         45       41       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cre8
Copy link
Contributor

cre8 commented Mar 11, 2024

@lukasjhan code looks good, can you add missing tests before merging?

@lukasjhan
Copy link
Member Author

Okay :) I'm working on it

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
@c2bo
Copy link

c2bo commented Mar 11, 2024

error - 2024-03-11 13:57:57,128 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 545 seconds."}
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
@lukasjhan
Copy link
Member Author

error - 2024-03-11 13:57:57,128 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 545 seconds."}
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

There is a token. It's strange. We're trying to find out why.

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
This reverts commit e972619.

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
@cre8 cre8 merged commit 9f28a26 into openwallet-foundation-labs:next Mar 11, 2024
10 checks passed
cre8 pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification for jwt and kb+jwt reconstruct base64 encoding
3 participants