Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible problems detected via CodeQL codescanning workflow #103

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Fix possible problems detected via CodeQL codescanning workflow #103

merged 1 commit into from
Aug 27, 2022

Conversation

speters
Copy link
Member

@speters speters commented Aug 26, 2022

This fixes possible problems being detected by the CodeQL codescanning workflow.

Problems contained:

Please be so kind as to test this version.

@speters speters merged commit 8982025 into openv:master Aug 27, 2022
@hmueller01
Copy link
Collaborator

I think it is not good to merge a pull request right away. This way it is not possible to add more changes.
In many cases the reserved memory char string[100]; is not needed any more.
I'll pull the new master and test it. :-)

@hmueller01
Copy link
Collaborator

New version is running. I'll open a new PR to remove these unused string's ...

@hmueller01 hmueller01 mentioned this pull request Aug 27, 2022
@speters
Copy link
Member Author

speters commented Aug 27, 2022

I was solely concetrated on those easy fixes.
Shame on me. And thx for having an eye on it.

@hmueller01
Copy link
Collaborator

Until now it works like before. As it is already merged it can be released ;-)
Pls review #105 (I tested with this PR ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants