UCT/TCP: Add assert to check that don't send CM data when connected #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrygx
force-pushed
the
topic/uct/tcp_assert_cm
branch
from
9bd7698
to
5d9c560
Compare
Mellanox CI: UNKNOWN on 25 workers (click for details)Note: the logs will be deleted after 17-Dec-2019
|
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 17-Dec-2019
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dmitrygx
force-pushed
the
topic/uct/tcp_assert_cm
branch
from
5d9c560
to
0ce9394
Compare
Mellanox CI: FAILED on 25 of 25 workers (click for details)Note: the logs will be deleted after 18-Dec-2019
|
|
bot:retest |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 18-Dec-2019
|
hoopoepg
approved these changes
Dec 12, 2019
brminich
approved these changes
Dec 12, 2019
dmitrygx
force-pushed
the
topic/uct/tcp_assert_cm
branch
from
0ce9394
to
80a2251
Compare
yosefe
reviewed
Dec 12, 2019
| @@ -156,6 +156,9 @@ ucs_status_t uct_tcp_cm_send_event(uct_tcp_ep_t *ep, uct_tcp_cm_conn_event_t eve | |||
| UCT_TCP_CM_CONN_ACK | | |||
| UCT_TCP_CM_CONN_WAIT_REQ)), | |||
| "ep=%p", ep); | |||
| ucs_assertv(!(ep->ctx_caps & UCS_BIT(UCT_TCP_EP_CTX_TYPE_TX)) || | |||
There was a problem hiding this comment.
if it does not have TX capability (i.e. only RX capability) and it is in CONNECTED state, it has to be able to send CM REQ event to a peer in order to set RX capability for the peer
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 19-Dec-2019
|
yosefe
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add assert to check that don't send CM data when connected
Why ?
In order to catch potential bug found by #4525 and #4406
How ?
Add assert and fix comment (
them->they)