This repository has been archived by the owner on Sep 27, 2022. It is now read-only.
audioAcquisitionProblem event now has an event with a method property #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 13, 2017 16:24
This reverts commit be577c1.
These tests were causing exceptions to be logged in Sentry.
leahciMic
previously approved these changes
Aug 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
audioAcquisitionProblem event now has an event with a method property so passing the method in our tests too. These tests were causing exceptions to be logged in Sentry.
How should this be manually tested?
Just make sure the tests pass and that there aren't new errors being logged in Sentry.