Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename browse controller to features/queries controller #5024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Collaborator

Version 2 of #4616.

BrowseController only did feature queries. #4616 renamed it to QueriesController but that wasn't entirely ok becouse it didn't tell what was queried.

Here I'm renaming it to Features::QueriesController.

@tomhughes
Copy link
Member

Are we every likely to have anything else in Features though? Maybe it should just be FeatureQueries instead?

Also should it be singular Query rather than Queries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants