Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added conditional SystemD support for notify #251

Closed
wants to merge 1 commit into from

Conversation

expeditioneer
Copy link

This adds SystemD notify support.

Based on patch of Jakub Jelen jjelen@redhat.com from RedHat / CentOS packaging.

configure.ac Outdated
SYSTEMD_CFLAGS=`$PKGCONFIG --cflags libsystemd`
SYSTEMD_LIBS=`$PKGCONFIG --libs libsystemd`
CPPFLAGS="$CPPFLAGS $SYSTEMD_CFLAGS"
+ SSHDLIBS="$SSHDLIBS $SYSTEMD_LIBS"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ SSHDLIBS="$SSHDLIBS $SYSTEMD_LIBS"
SSHDLIBS="$SSHDLIBS $SYSTEMD_LIBS"

I had to remove this superfluous + character to get the SSHDLIBS popluted correctly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this.

based on patch of Jakub Jelen <jjelen@redhat.com>
@spacexnasa
Copy link

hello,@expeditioneer, i tested openssh-9.4p1 centos 7,cann't work,if you hava time,can make a test ?

@djmdjm
Copy link
Contributor

djmdjm commented Mar 30, 2024

We're not interested in taking a dependency on libsystemd, see https://bugzilla.mindrot.org/show_bug.cgi?id=2641 for the approach we are likely to take.

@djmdjm djmdjm closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants