Macro-generated connectConnector methods. #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseth1
approved these changes
Dec 13, 2016
| @@ -857,7 +859,14 @@ class Input : public AbstractInput { | |||
| "Path to a Component to satisfy the Connector '" \ | |||
| #cname "' of type " #T " (description: " comment ").") \ | |||
| }; \ | |||
| /** @endcond */ | |||
| /** @endcond */ \ | |||
There was a problem hiding this comment.
Update auto generated comment for the property to : "Path to a Component that satisfies the Connector ` ... "
|
@aseth1 I have addressed your comment. |
|
Ready for review. |
|
LGTM 👍 @aymanhab? |
|
LGTM as well. Thanks @chrisdembia |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the counterpart to #1441 for connectors. The original plan was to rename connectors to sockets first before introducing the
connectSocket_*()macro function. But we decided to switch the order of these changes, since having the macro-generated method in place for the alpha release is perhaps more important than having the rename to sockets for the alpha.This is my second attempt at creating this PR, as #1446 shows an outdated diff (from before #1441 was merged).