Bug 1870489: Verify that tests correctly handle not rounding to the GiB

[derek-pryor]

Verify that PR #199 addresses Issue #94128 by changing the vSphere tests to use a non GiB aligned minimum value. The vSphere CSI driver is used because it is one of the few drivers that doesn't round to the GiB.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: derek-pryor
To complete the pull request process, please assign jsafrane after the PR has been reviewed.
You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@derek-pryor: This pull request references Bugzilla bug 1870489, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1870489: Verify that tests correctly handle not rounding to the GiB

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[derek-pryor]

/assign @jsafrane

[jsafrane]

/hold
this should not be merged :-)
/retest

[openshift-ci]

@derek-pryor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-csi-migration	72ee11f	link	false	/test e2e-vsphere-csi-migration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jsafrane]

I can see that the CSI driver got most of the CreateVolume requests call asking for 100MiB (=104857600 bytes) volume:

{"level":"info","time":"2022-01-11T11:11:51.316330798Z","caller":"vanilla/controller.go:803","msg":"CreateVolume: called with args {Name:pvc-95f552ba-0735-4fee-9cb9-fb050195e646 CapacityRange:required_bytes:104857600  ...

In the same log file I can see four requests for 1GiB (1073741824 bytes):

PV name	Volume ID
pvc-85fdad58-0a18-49cb-be11-23284f75bf2a	f74d86e4-7287-4113-83b4-6fccea8845f9
pvc-f61e8ceb-e245-47b1-a4c2-0d4167214684	536e8d14-9f75-440a-a205-25b1d39d3ccf
pvc-46cf5f46-f7d4-46f3-81de-2bb33604b17b	59223534-0185-410c-bb02-637c7bf9058c
pvc-a11b90a1-574e-48ae-b9d5-793ec6e9cb84	66bccd2e-4a18-4450-b9ba-c347fc6fa2f0

I can see ControllerExpandVolume was called on each of them (in the other driver log file), hence I deduct that these are volume expansion tests that use 1GiB as their minimal volume size for testing.

We can conclude that today's external-provisioner does not round volumes to 1GiB and there is nothing to fix.

[derek-pryor]

Closing as verification was successful.