Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Add the possibility of using a dedicated private key #693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the possibility of using a dedicated private key #693

wants to merge 1 commit into from

Conversation

IshentRas
Copy link

  • The current rhc command relies on finding the private key inside the home directory of the user running the command.
  • In addition it also expects the common name id_rsa or id_dsa
    This change gives the user the ability of defining a dedicated private key.

@tiwillia
Copy link
Member

[test]

@openshift-bot
Copy link

@openshift-bot
Copy link

Evaluated for online test up to 0bb8629

context 'when custom private key is inaccessible' do
let(:arguments) { ['app', 'ssh', 'app1', '--key', 'inaccessible_private_key'] }
it { expect { run }.to exit_with_code(1) }
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "private key is inaccessible" different from the "private key does not exist" test?

@Miciah
Copy link
Contributor

Miciah commented Nov 5, 2015

@tiwillia pointed out to me that the --key option (or --ssh_key if you decide to rename it) would be applicable to the ssh, scp, tail, snapshot, and port-forward commands as well, so it should be a global option. Could you please make that change, @IshentRas?

Edit: If you think it would be helpful to you, please refer to https://github.com/openshift/rhc/pull/696/files as an example of changing a command-specific option into a global option.

@openshift-bot
Copy link

openshift-bot commented Nov 10, 2015

Online Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants