Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/cluster-version-operator: auto_label for merge #1778

Conversation

wking
Copy link

@wking wking commented Jul 12, 2022

Currently 4.12 is the dev release, so it only needs lgtm and approved. But eventually 4.12 will hit code-freeze, and then it will also need bugzilla/valid-bug and staff-eng-approved. And eventually it will be a generally available release, and then it will need approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, and lgtm. The CVO is very flexible about Go versions and whatnot, so we don't need any of these sign-offs for CI-alignment pull requests. With this commit, we add all the labels we'll need to merge at any stage of the 4.12 lifecycle. And hopefully the same configuration will propagate into 4.13 once we get release branches here for that.

Currently 4.12 is the dev release, so it only needs lgtm and approved
[1].  But eventually 4.12 will hit code-freeze, and then it will also
need bugzilla/valid-bug and staff-eng-approved [2].  And eventually it
will be a generally available release, and then it will need approved,
backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, and
lgtm [3].  The CVO is very flexible about Go versions and whatnot, so
we don't need any of these sign-offs for CI-alignment pull requests.
With this commit, we add all the labels we'll need to merge at any
stage of the 4.12 lifecycle.  And hopefully the same configuration
will propagate into 4.13 once we get release branches here for that.

[1]: https://github.com/openshift/release/blob/7114512b31971dcfe83454a40ed77f8881cecc73/core-services/prow/02_config/openshift/cluster-version-operator/_prowconfig.yaml#L57-L62
[2]: https://github.com/openshift/release/blob/7114512b31971dcfe83454a40ed77f8881cecc73/core-services/prow/02_config/openshift/cluster-version-operator/_prowconfig.yaml#L40-L47
[3]: https://github.com/openshift/release/blob/7114512b31971dcfe83454a40ed77f8881cecc73/core-services/prow/02_config/openshift/cluster-version-operator/_prowconfig.yaml#L3-L30
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2022

@wking: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

images/cluster-version-operator: auto_label for merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Build #1

Validating 1 file(s)...
Validating images/cluster-version-operator.yml...
✅ Validated images/cluster-version-operator.yml

Copy link
Contributor

@vfreex vfreex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@thiagoalessio thiagoalessio merged commit a9c9dae into openshift-eng:openshift-4.12 Jul 13, 2022
@wking wking deleted the auto-label-cluster-version-operator-stream-pulls branch July 13, 2022 17:47
This was referenced Sep 20, 2023
This was referenced Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants