-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text around what to do on a deprovision when there are bindings #314
Conversation
Hey duglin! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
spec.md
Outdated
It is RECOMMENDED that platforms delete all bindings for a service prior | ||
to attempting to deprovision the service. If a broker receives a deprovision | ||
request for a service that has bindings, then the broker MAY attempt | ||
to delete all bindings prior deprovisioning the service. Any error during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prior to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
AI: Switch to 422 per today's call |
Need reviews |
@mattmcneeney yep - missed that - done now |
1 similar comment
Closes openservicebrokerapi#127 Basic does this: - clarify in the spec that it is RECOMMENDED that platforms delete all Bindings prior to deleting an Instance - brokers MAY support deleting an Instance that still has bindings (causing a cascading delete), but if they don't then we'll specify the exact error that MUST be returned - platforms MAY attempt to delete an Instance that still has Bindings, but if they get the well defined error then they MUST delete the bindings first. Signed-off-by: Doug Davis <dug@us.ibm.com>
Completed AI from previous call: |
another round of reviews needed. |
@@ -1021,6 +1021,11 @@ delete any resources it created during the provision. | |||
Usually this means that all resources are immediately reclaimed for future | |||
provisions. | |||
|
|||
Platforms MUST delete all bindings for a service prior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we change this to "MUST"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed during the call
Closes #127
Basic does this:
Signed-off-by: Doug Davis dug@us.ibm.com