Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Disable flaky test in JdbcTestIT. #478

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f154faa from #475

Signed-off-by: penghuo <penghuo@gmail.com>
(cherry picked from commit f154faa)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 10, 2022 00:19
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dco fails because this commit was authored with github name Peng Huo, but signed off as penghuo. It didn't fail before because it was commited locally with penghuo which matches signoff. To fix it you can change local git user.name to be consistent with github settings

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #478 (9b52204) into 1.x (eb1ede4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.x     #478   +/-   ##
=========================================
  Coverage     95.25%   95.25%           
  Complexity     2746     2746           
=========================================
  Files           276      276           
  Lines          7414     7414           
  Branches        538      538           
=========================================
  Hits           7062     7062           
  Misses          298      298           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb1ede4...9b52204. Read the comment docs.

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@penghuo penghuo merged commit 4401791 into 1.x Mar 10, 2022
@github-actions github-actions bot deleted the backport/backport-475-to-1.x branch March 10, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants