Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exception when datasource is updated with existing configuration. #2006

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

vamsi-amazon
Copy link
Member

@vamsi-amazon vamsi-amazon commented Aug 22, 2023

Description

In the current state when datasource is updated with existing configuration, it results in 503 error.
With this PR, it returns 200.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #2006 (4353a32) into main (6055c7e) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2006   +/-   ##
=========================================
  Coverage     97.30%   97.30%           
- Complexity     4622     4623    +1     
=========================================
  Files           407      407           
  Lines         11934    11935    +1     
  Branches        827      828    +1     
=========================================
+ Hits          11612    11613    +1     
  Misses          315      315           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/storage/OpenSearchDataSourceMetadataStorage.java 98.75% <100.00%> (+<0.01%) ⬆️

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 22, 2023
#2006)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit b3fd4c4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 22, 2023
#2006)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit b3fd4c4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon pushed a commit that referenced this pull request Aug 22, 2023
#2006) (#2009)

(cherry picked from commit b3fd4c4)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon pushed a commit that referenced this pull request Aug 22, 2023
#2006) (#2008)

(cherry picked from commit b3fd4c4)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.9 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants